Smart Contract Audit Report
NFTPussies is a developing a new token on the Binance Smart Chain with bot mitigation properties.
For this audit, we reviewed the project team's NFTPussies contract at 0x91D74E31A2734F4E519861aB9917048822f0B489 on the Binance Smart Chain Mainnet.
Please ensure trust in the team prior to investing as they have substantial control in the ecosystem.
Date: March 29th, 2022.
Finding #1 - NFTPussies - LowDescription: The
isContract()function can be bypassed by a contract that calls the
transfer()function within its constructor.
Risk/Impact: A contract would be able to transfer tokens while trading is disabled.
Recommendation: The team should verify that the tx.origin address equals the
msg.senderaddress in the case where "sender" address passed into the
_transfer()function is the
Finding #2 - NFTPussies - InformationalDescription: The contract does not contain functionality to add or remove addresses to the
Risk/Impact: User addresses cannot be individually blocked from transferring tokens.
Recommendation: The team should remove this functionality as it is not used within the contract.
Finding #3 - NFTPussies - InformationalDescription: Several functions are declared public, but are never called internally.Recommendation: We recommend declaring these functions external for additional gas savings on each call.
NFTPussies.setAllowedContract, NFTPussies.setLiquidityPair, NFTPussies.setBuyTax, NFTPussies.setSellTax, NFTPussies.setTrading, NFTPussies.setAntibotBlocks, NFTPussies.getAntibotInfo
- The total supply of $PUSSIES is currently 1 billion [1,000,000,000].
- There is no mint function so there is no way for the team to increase the total supply after the initial amount.
- Any user can burn their own tokens to reduce the total supply.
- Additionally, users can burn tokens from other addresses up to the amount of allowance they've been granted, also reducing the total supply.
- At the time of writing this report, 95.72% of the total supply is held by the owner.
- The second top token holder address holds 2.10%.
- 0.70% is stored in a Presale contract. This contract was out of scope for the purpose of this audit.
- The next five holders own a cumulative 0.74% of the total supply.
- Users can transfer tokens while trading is enabled and neither the sender nor recipient are blacklisted. As described in Finding #2 above, there is no way to add addresses to the blacklist.
- An anti-bot fee is charged on all token buys and sells from non-tax exempt addresses during the anti-bot block period; a token buy or sell is based on whether the sender or receiver address is on the liquidity pair address list.
- The anti-bot fee is calculated based on the percentage of blocks left within the anti-bot block period from the initial start block.
- The anti-bot block period is set on deployment and begins once trading is initially enabled within the contract.
- Additionally, there are purchasing and selling taxes charged on transfers to and from liquidity pair addresses unless the sender or receiver address is tax exempt; the owner is exempted on deployment.
- All fees are stored in the contract.
- While trading is disabled, only the owner and whitelisted contract addresses can transfer tokens.
- The owner can transfer ownership at any time.
- The owner can toggle trading at any time.
- The owner can whitelist any contract address at any time.
- The owner can add any liquidity pair address to the approved liquidity pair list at any time.
- The owner can add or remove any address from the tax exemption list.
- The owner can set the anti-bot block period to any amount of up to 20 blocks at any time.
- The owner can set the buying and selling taxes to any value up to 30% at any time.
- The contract complies with the ERC-20 standard.
- As the contract is deployed with Solidity v0.8.x, it is protected from overflow/underflow attacks.
|Arbitrary Jump/Storage Write||N/A||PASS|
|Centralization of Control||WARNING|
|Delegate Call to Untrusted Contract||N/A||PASS|
|Dependence on Predictable Variables||N/A||PASS|
|Improper Authorization Scheme||The ||PASS|
|Outdated Compiler Version||N/A||PASS|
|Overall Contract Safety||PASS|
($) = payable function # = non-constant function Int = Internal Ext = External Pub = Public + [Int] IERC20 - [Ext] totalSupply - [Ext] balanceOf - [Ext] transfer # - [Ext] allowance - [Ext] approve # - [Ext] transferFrom # + [Int] IERC20Metadata (IERC20) - [Ext] name - [Ext] symbol - [Ext] decimals + Context - [Int] _msgSender - [Int] _msgData + ERC20 (Context, IERC20, IERC20Metadata) - [Pub]
# - [Pub] name - [Pub] symbol - [Pub] decimals - [Pub] totalSupply - [Pub] balanceOf - [Pub] transfer # - [Pub] allowance - [Pub] approve # - [Pub] transferFrom # - [Pub] increaseAllowance # - [Pub] decreaseAllowance # - [Int] _transfer # - [Int] _mint # - [Int] _burn # - [Int] _approve # - [Int] _spendAllowance # - [Int] _beforeTokenTransfer # - [Int] _afterTokenTransfer # + ERC20Burnable (Context, ERC20) - [Pub] burn # - [Pub] burnFrom # + Ownable (Context) - [Pub] # - [Pub] owner - [Pub] renounceOwnership # - modifiers: onlyOwner - [Pub] transferOwnership # - modifiers: onlyOwner - [Int] _transferOwnership # + [Lib] Address - [Int] isContract - [Int] sendValue # - [Int] functionCall # - [Int] functionCall # - [Int] functionCallWithValue # - [Int] functionCallWithValue # - [Int] functionStaticCall - [Int] functionStaticCall - [Int] functionDelegateCall # - [Int] functionDelegateCall # - [Int] verifyCallResult + [Int] IPresale - [Ext] buyTokensWithBNB ($) - [Ext] buyTokensWithToken # + NFTPussies (ERC20Burnable, Ownable) - [Pub] # - modifiers: ERC20 - [Pub] setAllowedContract # - modifiers: onlyOwner - [Pub] setLiquidityPair # - modifiers: onlyOwner - [Pub] setIgnoreTax # - modifiers: onlyOwner - [Pub] setBuyTax # - modifiers: onlyOwner - [Pub] setSellTax # - modifiers: onlyOwner - [Pub] setTrading # - modifiers: onlyOwner - [Pub] setAntibotBlocks # - modifiers: onlyOwner - [Pub] rescueTokens # - modifiers: onlyOwner - [Pub] getAntibotInfo - modifiers: onlyOwner - [Prv] antibot # - [Int] _transfer #
About Solidity Finance
Solidity Finance was founded in 2020 and quickly grew to have one of the most experienced and well-equipped smart contract auditing teams in the industry. Our team has conducted 1000+ solidity smart contract audits covering all major project types and protocols, securing a total of over $10 billion U.S. dollars in on-chain value.
Our firm is well-reputed in the community and is trusted as a top smart contract auditing company for the review of solidity code, no matter how complex. Our team of experienced solidity smart contract auditors performs audits for tokens, NFTs, crowdsales, marketplaces, gambling games, financial protocols, and more!
Contact us today to get a free quote for a smart contract audit of your project!
What is a Solidity Audit?
Typically, a smart contract audit is a comprehensive review process designed to discover logical errors, security vulnerabilities, and optimization opportunities within code. A Solidity Audit takes this a step further by verifying economic logic to ensure the stability of smart contracts and highlighting privileged functionality to create a report that is easy to understand for developers and community members alike.
How Do I Interpret the Findings?
Each of our Findings will be labeled with a Severity level. We always recommend the team resolve High, Medium, and Low severity findings prior to deploying the code to the mainnet. Here is a breakdown on what each Severity level means for the project:
- High severity indicates that the issue puts a large number of users' funds at risk and has a high probability of exploitation, or the smart contract contains serious logical issues which can prevent the code from operating as intended.
- Medium severity issues are those which place at least some users' funds at risk and has a medium to high probability of exploitation.
- Low severity issues have a relatively minor risk association; these issues have a low probability of occurring or may have a minimal impact.
- Informational issues pose no immediate risk, but inform the project team of opportunities for gas optimizations and following smart contract security best practices.